linux-kernel - Re: [PATCH V2 19/19] vdpa: introduce virtio pci driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a17bd160-eda2-af4f-e465-23d29ca0580a@redhat.com>
Date:   Mon, 4 Jan 2021 11:28:05 +0800
From:   Jason Wang <jasowang@...hat.com>
To:     Stefano Garzarella <sgarzare@...hat.com>
Cc:     mst@...hat.com, virtualization@...ts.linux-foundation.org,
        linux-kernel@...r.kernel.org, shahafs@...lanox.com
Subject: Re: [PATCH V2 19/19] vdpa: introduce virtio pci driver


On 2020/12/4 下午11:20, Stefano Garzarella wrote:
>> +#define VP_VDPA_QUEUE_MAX 256
>> +#define VP_VDPA_DRIVER_NAME "vp_vdpa"
>> +
>> +struct vp_vring {
>> +    void __iomem *notify;
>> +    char msix_name[256];
>
> Can we use a macro for the msix_name size, since we use 256 in 
> multiple places?


Yes, will switch to use a macro.


>
>> +    struct vdpa_callback cb;
>> +    int irq;
>> +};
>> +
>> +struct vp_vdpa {
>> +    struct vdpa_device vdpa;
>> +    struct virtio_pci_modern_device mdev;
>> +    struct vp_vring *vring;
>> +    struct vdpa_callback cb;
>                              ^
> It is not relevant, but 'config_cb' is maybe clearer to read.
>

Will change to config_cb.


> The rest looks good.


Thanks


>
> Thanks,
> Stefano