lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Mon, 4 Jan 2021 13:23:41 +0100
From:   Stephan Gerhold <stephan@...hold.net>
To:     Konrad Dybcio <konrad.dybcio@...ainline.org>
Cc:     phone-devel@...r.kernel.org, ~postmarketos/upstreaming@...ts.sr.ht,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Ohad Ben-Cohen <ohad@...ery.com>,
        linux-arm-msm@...r.kernel.org, linux-remoteproc@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH RFC] remoteproc: qcom: wcnss: Adjust voltage requirements
 for Pronto v2

Hi Konrad,

On Sat, Dec 26, 2020 at 03:11:00PM +0100, Konrad Dybcio wrote:
> This is required for MSM8974 devices that cannot afford to push
> the regulators further.
> 
> Signed-off-by: Konrad Dybcio <konrad.dybcio@...ainline.org>
> ---
>  drivers/remoteproc/qcom_wcnss.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/remoteproc/qcom_wcnss.c b/drivers/remoteproc/qcom_wcnss.c
> index e2573f79a137..71480be545e4 100644
> --- a/drivers/remoteproc/qcom_wcnss.c
> +++ b/drivers/remoteproc/qcom_wcnss.c
> @@ -124,7 +124,7 @@ static const struct wcnss_data pronto_v2_data = {
>  	.spare_offset = 0x1088,
>  
>  	.vregs = (struct wcnss_vreg_info[]) {
> -		{ "vddmx", 1287500, 1287500, 0 },
> +		{ "vddmx", 950000, 1150000, 0 },
>  		{ "vddcx", .super_turbo = true },
>  		{ "vddpx", 1800000, 1800000, 0 },
>  	},

Correct me if I'm wrong but with this change pronto_v2_data looks
exactly like pronto_v1_data (qcom,pronto-v1-pil).
Can you just change the compatible in qcom-msm8974.dtsi?

Also, if possible MSM8974 should be also moved to corner votes via rpmpd,
like in https://lore.kernel.org/linux-arm-msm/20200916104135.25085-1-stephan@gerhold.net/
Then the actual voltages don't matter anymore (all we need to do here is
to temporarily scale the power domain to maximum so WCNSS can boot up).

Thanks,
Stephan

Powered by blists - more mailing lists