linux-kernel - Re: [PATCH] dmaengine: qcom: fix gpi undefined behavior

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210104123848.GG120946@vkoul-mobl>
Date:   Mon, 4 Jan 2021 18:08:48 +0530
From:   Vinod Koul <vkoul@...nel.org>
To:     Arnd Bergmann <arnd@...nel.org>
Cc:     Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Arnd Bergmann <arnd@...db.de>,
        Dan Williams <dan.j.williams@...el.com>,
        linux-arm-msm@...r.kernel.org, dmaengine@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dmaengine: qcom: fix gpi undefined behavior

On 03-01-21, 14:57, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> gcc points out an incorrect error handling loop:
> 
> drivers/dma/qcom/gpi.c: In function 'gpi_ch_init':
> drivers/dma/qcom/gpi.c:1254:15: error: iteration 2 invokes undefined behavior [-Werror=aggressive-loop-optimizations]
>  1254 |  struct gpii *gpii = gchan->gpii;
>       |               ^~~~
> drivers/dma/qcom/gpi.c:1951:2: note: within this loop
>  1951 |  for (i = i - 1; i >= 0; i++) {
>       |  ^~~
> 
> Change the loop to correctly walk backwards through the
> initialized fields rather than off into the woods.

Applied, thanks

-- 
~Vinod