lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 4 Jan 2021 09:41:37 +0530 From: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org> To: miquel.raynal@...tlin.com, richard@....at, vigneshr@...com, robh+dt@...nel.org Cc: bjorn.andersson@...aro.org, linux-mtd@...ts.infradead.org, devicetree@...r.kernel.org, linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org, Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>, Linus Walleij <linus.walleij@...aro.org> Subject: [PATCH v4 4/4] mtd: parsers: afs: Fix freeing the part name memory in failure In the case of failure while parsing the partitions, the iterator should be pre decremented by one before starting to free the memory allocated by kstrdup(). Because in the failure case, kstrdup() will not succeed and thus no memory will be allocated for the current iteration. Fixes: 1fca1f6abb38 ("mtd: afs: simplify partition parsing") Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org> Reviewed-by: Linus Walleij <linus.walleij@...aro.org> Cc: Linus Walleij <linus.walleij@...aro.org> --- drivers/mtd/parsers/afs.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/mtd/parsers/afs.c b/drivers/mtd/parsers/afs.c index 980e332bdac4..26116694c821 100644 --- a/drivers/mtd/parsers/afs.c +++ b/drivers/mtd/parsers/afs.c @@ -370,10 +370,8 @@ static int parse_afs_partitions(struct mtd_info *mtd, return i; out_free_parts: - while (i >= 0) { + while (--i >= 0) kfree(parts[i].name); - i--; - } kfree(parts); *pparts = NULL; return ret; -- 2.25.1
Powered by blists - more mailing lists