linux-kernel - Re: [PATCH] ACPI / scan: Don't create platform device for INT3515 ACPI nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 4 Jan 2021 14:59:28 +0100
From:   Hans de Goede <hdegoede@...hat.com>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
        "Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
        Mark Gross <mgross@...ux.intel.com>,
        platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org,
        Moody Salem <moody@...swap.org>, stable@...r.kernel.org
Subject: Re: [PATCH] ACPI / scan: Don't create platform device for INT3515
 ACPI nodes

Hi,

On 1/4/21 1:23 PM, Andy Shevchenko wrote:
> On Mon, Jan 04, 2021 at 12:59:39PM +0100, Hans de Goede wrote:
>> On 12/23/20 3:36 PM, Heikki Krogerus wrote:
>>> There are several reports about the tps6598x causing
>>> interrupt flood on boards with the INT3515 ACPI node, which
>>> then causes instability. There appears to be several
>>> problems with the interrupt. One problem is that the
>>> I2CSerialBus resources do not always map to the Interrupt
>>> resource with the same index, but that is not the only
>>> problem. We have not been able to come up with a solution
>>> for all the issues, and because of that disabling the device
>>> for now.
>>>
>>> The PD controller on these platforms is autonomous, and the
>>> purpose for the driver is primarily to supply status to the
>>> userspace, so this will not affect any functionality.
>>>
>>> Reported-by: Moody Salem <moody@...swap.org>
>>> Fixes: a3dd034a1707 ("ACPI / scan: Create platform device for INT3515 ACPI nodes")
>>> Cc: stable@...r.kernel.org
>>> Link: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1883511
>>> Signed-off-by: Heikki Krogerus <heikki.krogerus@...ux.intel.com>
>>
>> Thank you for your patch, I've applied this patch to my review-hans 
>> branch:
>> https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans
>>
>> Note it will show up in my review-hans branch once I've pushed my
>> local branch there, which might take a while.
>>
>> Once I've run some tests on this branch the patches there will be
>> added to the platform-drivers-x86/for-next branch and eventually
>> will be included in the pdx86 pull-request to Linus for the next
>> merge-window.
> 
> I'm wondering if my reply has been seen...
> 
> https://lore.kernel.org/platform-driver-x86/ae94a191-4273-0000-deda-4859034343b8@redhat.com/T/#m30308ca22cd0ce266aa6913ab7ef1fc56b3279de

Yes I've done the s/Link/BugLink/ in the commit msg and fixed up the
typo-s in the comment block locally. I should have mentioned that in
my reply instead of just blindly using the template-reply which I have for
this, sorry; and thank you for the review.

Regards,

Hans