[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20210104140110.GQ2809@kadam>
Date: Mon, 4 Jan 2021 17:01:10 +0300
From: Dan Carpenter <dan.carpenter@...cle.com>
To: Zheng Yongjun <zhengyongjun3@...wei.com>
Cc: nsaenzjulienne@...e.de, bcm-kernel-feedback-list@...adcom.com,
devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] staging: vc04_services: use DEFINE_MUTEX (and
mutex_init() had been too late)
On Wed, Dec 23, 2020 at 10:11:29PM +0800, Zheng Yongjun wrote:
> Signed-off-by: Zheng Yongjun <zhengyongjun3@...wei.com>
> ---
> .../vc04_services/interface/vchiq_arm/vchiq_connected.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_connected.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_connected.c
> index 79b75efa6868..864253866155 100644
> --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_connected.c
> +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_connected.c
> @@ -12,13 +12,12 @@ static int g_connected;
> static int g_num_deferred_callbacks;
> static VCHIQ_CONNECTED_CALLBACK_T g_deferred_callback[MAX_CALLBACKS];
> static int g_once_init;
> -static struct mutex g_connected_mutex;
> +static DEFINE_MUTEX(g_connected_mutex);
>
> /* Function to initialize our lock */
> static void connected_init(void)
> {
> if (!g_once_init) {
> - mutex_init(&g_connected_mutex);
> g_once_init = 1;
> }
Delete the extra curly braces.
regards,
dan carpenter
Powered by blists - more mailing lists