linux-kernel - Re: [PATCH] HID: sfh: fix address space confusion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <nycvar.YFH.7.76.2101041608141.13752@cbobk.fhfr.pm>
Date:   Mon, 4 Jan 2021 16:08:32 +0100 (CET)
From:   Jiri Kosina <jikos@...nel.org>
To:     Arnd Bergmann <arnd@...nel.org>
cc:     Nehal Shah <nehal-bakulchandra.shah@....com>,
        Sandeep Singh <sandeep.singh@....com>,
        Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        Arnd Bergmann <arnd@...db.de>, linux-input@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] HID: sfh: fix address space confusion

On Sun, 3 Jan 2021, Arnd Bergmann wrote:

> From: Arnd Bergmann <arnd@...db.de>
> 
> The new driver uses a phys_addr_t to store a DMA address,
> which does not work when the two are different size:
> 
> drivers/hid/amd-sfh-hid/amd_sfh_client.c:157:11: error: incompatible pointer types passing 'phys_addr_t *' (aka 'unsigned int *') to parameter of type 'dma_addr_t *' (aka 'unsigned long long *') [-Werror,-Wincompatible-pointer-types]
>                                                                   &cl_data->sensor_phys_addr[i],
>                                                                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> include/linux/dma-mapping.h:393:15: note: passing argument to parameter 'dma_handle' here
>                 dma_addr_t *dma_handle, gfp_t gfp)
>                             ^
> 
> Change both the type and the variable name to dma_addr for consistency.
> 
> Fixes: 4b2c53d93a4b ("SFH:Transport Driver to add support of AMD Sensor Fusion Hub (SFH)")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Good catch; queued for 5.11, thanks.

-- 
Jiri Kosina
SUSE Labs