linux-kernel - Re: [PATCH 1/2] rtc: goldfish: Remove GOLDFISH dependency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210104154303.GD3313@piout.net>
Date:   Mon, 4 Jan 2021 16:43:03 +0100
From:   Alexandre Belloni <alexandre.belloni@...tlin.com>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:     Jiaxun Yang <jiaxun.yang@...goat.com>,
        "open list:BROADCOM NVRAM DRIVER" <linux-mips@...r.kernel.org>,
        Alessandro Zummo <a.zummo@...ertech.it>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-rtc@...r.kernel.org
Subject: Re: [PATCH 1/2] rtc: goldfish: Remove GOLDFISH dependency

On 04/01/2021 16:21:31+0100, Geert Uytterhoeven wrote:
> Hi Alexandre,
> 
> On Mon, Jan 4, 2021 at 3:48 PM Alexandre Belloni
> <alexandre.belloni@...tlin.com> wrote:
> > On 04/01/2021 14:28:26+0100, Geert Uytterhoeven wrote:
> > > On Sat, Nov 14, 2020 at 2:20 PM Jiaxun Yang <jiaxun.yang@...goat.com> wrote:
> > > > Goldfish platform is covered with dust.
> > > > However the goldfish-rtc had been used as virtualized RTC
> > > > in QEMU for RISC-V virt hw and MIPS loongson3-virt hw, thus
> > > > we can drop other parts of goldfish but leave goldfish-rtc here.
> > > >
> > > > Signed-off-by: Jiaxun Yang <jiaxun.yang@...goat.com>
> > >
> > > Thanks for your patch!
> > >
> > > > --- a/drivers/rtc/Kconfig
> > > > +++ b/drivers/rtc/Kconfig
> > > > @@ -1935,7 +1935,6 @@ config RTC_DRV_HID_SENSOR_TIME
> > > >  config RTC_DRV_GOLDFISH
> > > >         tristate "Goldfish Real Time Clock"
> > > >         depends on OF && HAS_IOMEM
> > > > -       depends on GOLDFISH || COMPILE_TEST
> > > >         help
> > > >           Say yes to enable RTC driver for the Goldfish based virtual platform.
> > >
> > > I was just looking to see if someone had already sent a patch to add
> > > "depends on GOLDFISH || COMPILE_TEST", before sending one myself, when I
> > > noticed your patch had removed it...
> > >
> > > What about
> > >
> > >     depends on CPU_LOONGSON64 || GOLDFISH || RISCV || COMPILE_TEST
> > >
> > > instead?
> > >
> >
> > But this driver also works on ARM, is it really important to restrict to
> > a few architectures ?
> 
> Is it used on ARM platforms?
> qemu:hw/riscv/Kconfig selects GOLDFISH_RTC, but that's it?
> 

My understanding is that this was used on the original ARM based goldfish
android emulator but I don't think this was ever upstreamed.


-- 
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com