linux-kernel - Re: [PATCH v2 2/3] scsi: ufs: Add handling of the return value of pm_runtime_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <dd3a0f2e8c9688f98b1c5a3c843db0570e4da139.camel@gmail.com>
Date:   Mon, 04 Jan 2021 18:39:41 +0100
From:   Bean Huo <huobean@...il.com>
To:     Can Guo <cang@...eaurora.org>
Cc:     alim.akhtar@...sung.com, avri.altman@....com,
        asutoshd@...eaurora.org, jejb@...ux.ibm.com,
        martin.petersen@...cle.com, stanley.chu@...iatek.com,
        beanhuo@...ron.com, bvanassche@....org, tomas.winkler@...el.com,
        linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
        rjw@...ysocki.net
Subject: Re: [PATCH v2 2/3] scsi: ufs: Add handling of the return value of
 pm_runtime_get_sync()

On Mon, 2020-12-28 at 09:50 +0800, Can Guo wrote:
> > The race issue may exist between UFS access in UFS sysfs context
> > and 
> > UFS
> > shutdown, thus will cause pm_runtime_get_sync() resume failure.
> 
> Are you trying to fix the race condition by adding these checks or
> just
> adding these checks in case pm_runtime_get_sync() fails?
> 
> Can Guo.

Can,
thanks for your review. Sorry, I didn't quite get your point.
This patch is just to add checkup in case pm_runtime_get_sync() failed.

what else should be added?

Bean