linux-kernel - Re: [PATCH -tip v2] x86/kprobes: Do not decode opcode in resume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210104184051.GG32151@zn.tnic>
Date:   Mon, 4 Jan 2021 19:40:51 +0100
From:   Borislav Petkov <bp@...en8.de>
To:     Masami Hiramatsu <mhiramat@...nel.org>
Cc:     Ingo Molnar <mingo@...nel.org>,
        Steven Rostedt <rostedt@...dmis.org>,
        linux-kernel@...r.kernel.org,
        "Naveen N . Rao" <naveen.n.rao@...ux.ibm.com>,
        Anil S Keshavamurthy <anil.s.keshavamurthy@...el.com>,
        David Miller <davem@...emloft.net>, x86@...nel.org
Subject: Re: [PATCH -tip v2] x86/kprobes: Do not decode opcode in
 resume_execution()

On Mon, Jan 04, 2021 at 12:45:58PM +0900, Masami Hiramatsu wrote:
> Hrm, I meant setting the flags used in the resume_execution() afterwards.
> Since the instruction itself (not only opcode but also oprands) was
> also analyzed in other places, so I like the set_resume_flags() for it.

Your call but I still think that set_resume_flags() is misleading. You
even have in the comment above it:

"Analyze the opcode and set resume flags."

so it is doing some insn analysis and setting flags as a result.

But I won't insist - you're the one who's going to be staring at that
code.

:-)

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette