linux-kernel - Re: [PATCH 5.10 637/717] drm/amd/display: Fix memory leaks in S3 resume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210104201016.bncnhyq25zz2y76h@spock.localdomain>
Date:   Mon, 4 Jan 2021 21:10:16 +0100
From:   Oleksandr Natalenko <oleksandr@...alenko.name>
To:     Andre Tomt <andre@...t.net>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Harry Wentland <harry.wentland@....com>,
        Alex Deucher <alexander.deucher@....com>,
        Nicholas Kazlauskas <nicholas.kazlauskas@....com>,
        Stylon Wang <stylon.wang@....com>
Subject: Re: [PATCH 5.10 637/717] drm/amd/display: Fix memory leaks in S3
 resume

On Mon, Jan 04, 2021 at 08:04:08PM +0100, Andre Tomt wrote:
> On 28.12.2020 13:50, Greg Kroah-Hartman wrote:
> > From: Stylon Wang <stylon.wang@....com>
> > 
> > commit a135a1b4c4db1f3b8cbed9676a40ede39feb3362 upstream.
> > 
> > EDID parsing in S3 resume pushes new display modes
> > to probed_modes list but doesn't consolidate to actual
> > mode list. This creates a race condition when
> > amdgpu_dm_connector_ddc_get_modes() re-initializes the
> > list head without walking the list and results in  memory leak.
> 
> This commit is causing me problems on 5.10.4: when I turn off the display (a
> LG TV in this case), and turn it back on again later there is no video
> output and I get the following in the kernel log:
> 
> [ 8245.259628] [drm:dm_restore_drm_connector_state [amdgpu]] *ERROR*
> Restoring old state failed with -12

Uh, it seems you've just saved me a ton of gray hair. I have the very
same issue and I'm going to revert this patch now in order to check
whether it makes any difference.

Thanks!

> 
> I've found another report on this commit as well:
> https://bugzilla.kernel.org/show_bug.cgi?id=211033
> 
> And I suspect this is the same:
> https://bugs.archlinux.org/task/69202
> 
> Reverting it from 5.10.4 makes things behave again.
> 
> Have not tested 5.4.86 or 5.11-rc.
> 
> I'm using a RX570 Polaris based card.

-- 
  Oleksandr Natalenko (post-factum)