lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [day] [month] [year] [list]
Message-ID: <8cc65fcc-626e-6012-8d5e-0a0c5d608fab@amd.com>
Date:   Mon, 4 Jan 2021 16:20:55 -0500
From:   "Kazlauskas, Nicholas" <nicholas.kazlauskas@....com>
To:     "Deucher, Alexander" <Alexander.Deucher@....com>,
        Sasha Levin <sashal@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "stable@...r.kernel.org" <stable@...r.kernel.org>
Cc:     "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        "amd-gfx@...ts.freedesktop.org" <amd-gfx@...ts.freedesktop.org>,
        Bas Nieuwenhuizen <bas@...nieuwenhuizen.nl>
Subject: Re: [PATCH AUTOSEL 5.4 006/130] drm/amd/display: Do not silently
 accept DCC for multiplane formats.

On 2020-12-29 9:54 a.m., Deucher, Alexander wrote:
> [AMD Public Use]
> 
> 
> I don't know if these fixes related to modifiers make sense in the 
> pre-modifier code base.  Bas, Nick?
> 
> Alex

Mesa should be the only userspace trying to make use of DCC and it 
doesn't do it for video formats. From the kernel side of things we've 
also never supported this and you'd get corruption on the screen if you 
tried.

It's a "fix" for both pre-modifiers and post-modifiers code.

Regards,
Nicholas Kazlauskas

> ------------------------------------------------------------------------
> *From:* amd-gfx <amd-gfx-bounces@...ts.freedesktop.org> on behalf of 
> Sasha Levin <sashal@...nel.org>
> *Sent:* Tuesday, December 22, 2020 9:16 PM
> *To:* linux-kernel@...r.kernel.org <linux-kernel@...r.kernel.org>; 
> stable@...r.kernel.org <stable@...r.kernel.org>
> *Cc:* Sasha Levin <sashal@...nel.org>; dri-devel@...ts.freedesktop.org 
> <dri-devel@...ts.freedesktop.org>; amd-gfx@...ts.freedesktop.org 
> <amd-gfx@...ts.freedesktop.org>; Bas Nieuwenhuizen 
> <bas@...nieuwenhuizen.nl>; Deucher, Alexander 
> <Alexander.Deucher@....com>; Kazlauskas, Nicholas 
> <Nicholas.Kazlauskas@....com>
> *Subject:* [PATCH AUTOSEL 5.4 006/130] drm/amd/display: Do not silently 
> accept DCC for multiplane formats.
> From: Bas Nieuwenhuizen <bas@...nieuwenhuizen.nl>
> 
> [ Upstream commit b35ce7b364ec80b54f48a8fdf9fb74667774d2da ]
> 
> Silently accepting it could result in corruption.
> 
> Signed-off-by: Bas Nieuwenhuizen <bas@...nieuwenhuizen.nl>
> Reviewed-by: Alex Deucher <alexander.deucher@....com>
> Reviewed-by: Nicholas Kazlauskas <nicholas.kazlauskas@....com>
> Signed-off-by: Alex Deucher <alexander.deucher@....com>
> Signed-off-by: Sasha Levin <sashal@...nel.org>
> ---
>   drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c 
> b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> index d2dd387c95d86..ce70c42a2c3ec 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> @@ -2734,7 +2734,7 @@ fill_plane_dcc_attributes(struct amdgpu_device *adev,
>                   return 0;
> 
>           if (format >= SURFACE_PIXEL_FORMAT_VIDEO_BEGIN)
> -               return 0;
> +               return -EINVAL;
> 
>           if (!dc->cap_funcs.get_dcc_compression_cap)
>                   return -EINVAL;
> -- 
> 2.27.0
> 
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@...ts.freedesktop.org
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&amp;data=04%7C01%7Calexander.deucher%40amd.com%7Cfb9f2581393f494acd1708d8a6e905fc%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637442867044150000%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=ZYz1FjTl6SoWX1B91t0McdUai%2FzRF9C8uBmE%2BNQNod4%3D&amp;reserved=0 
> <https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&amp;data=04%7C01%7Calexander.deucher%40amd.com%7Cfb9f2581393f494acd1708d8a6e905fc%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637442867044150000%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=ZYz1FjTl6SoWX1B91t0McdUai%2FzRF9C8uBmE%2BNQNod4%3D&amp;reserved=0>

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ