linux-kernel - Re: [PATCH] spi: spidev: Fix so the module is autoloaded when built as external

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210104213437.GM5645@sirena.org.uk>
Date:   Mon, 4 Jan 2021 21:34:37 +0000
From:   Mark Brown <broonie@...nel.org>
To:     Gustav Wiklander <gustav.wiklander@...s.com>
Cc:     kernel@...s.com, Gustav Wiklander <gustavwi@...s.com>,
        linux-spi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] spi: spidev: Fix so the module is autoloaded when built
 as external

On Mon, Jan 04, 2021 at 04:34:35PM +0100, Gustav Wiklander wrote:
> From: Gustav Wiklander <gustavwi@...s.com>
> 
> The spi framework sets the modalias for the spi device to belong in
> either the acpi device table or the SPI device table. It can never
> be in the OF table. Therefore the spidev driver should populate the
> spi device table rather than the OF table.
> 
> NOTE: platform drivers and i2c drivers support aliases in the
>       OF device table.

Why is this a good solution rather than ensuring the the OF IDs can be
used directly?

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)