linux-kernel - Re: [PATCH] drivers: net: wireless: realtek: Fix the word association defautly de-faulty

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <23353e52-8a50-2024-e5b0-591d4e2f720e@lwfinger.net>
Date:   Tue, 5 Jan 2021 12:09:19 -0600
From:   Larry Finger <Larry.Finger@...inger.net>
To:     Joe Perches <joe@...ches.com>,
        Bhaskar Chowdhury <unixbhaskar@...il.com>,
        Julian Calaby <julian.calaby@...il.com>
Cc:     Ping-Ke Shih <pkshih@...ltek.com>,
        Kalle Valo <kvalo@...eaurora.org>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, zhengbin13@...wei.com,
        baijiaju1990@...il.com,
        Christophe JAILLET <christophe.jaillet@...adoo.fr>,
        linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drivers: net: wireless: realtek: Fix the word association
 defautly de-faulty

On 1/5/21 5:55 AM, Joe Perches wrote:
> On Tue, 2021-01-05 at 17:11 +0530, Bhaskar Chowdhury wrote:
>> On 22:24 Tue 05 Jan 2021, Julian Calaby wrote:
>>> Hi Bhaskar,
> []
>>> and your change is just making this comment worse.
>> really??? Not sure about it.
> 
> I agree with Julian.  I'm fairly sure it's worse.
> The change you suggest doesn't parse well and is extremely odd.
> If you _really_ want to just change this use (and the others),
> I repeat his suggestion of "by default".

I agree with Julian and Joe. Your suggested change makes it worse!

To match ALL previous commits/patches for these drivers, the subject should be 
"rtlwifi: <driver_name>: Fix description of usage of own bit in descriptor"

For all drivers, that comment should be written as:
         /* By default, a beacon packet will only use the first
          * descriptor and the own bit may not be cleared by the hardware
          */

Larry