linux-kernel - Re: [PATCH v2 07/18] ARM: dts: qcom: sdx55: Add support for TCSR Mutex

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 5 Jan 2021 12:20:53 -0600
From:   Bjorn Andersson <bjorn.andersson@...aro.org>
To:     Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
Cc:     agross@...nel.org, linux-arm-msm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 07/18] ARM: dts: qcom: sdx55: Add support for TCSR
 Mutex

On Tue 05 Jan 06:26 CST 2021, Manivannan Sadhasivam wrote:

> Add TCSR Mutex node to support Qualcomm Hardware Mutex block on SDX55
> platform.
> 
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
> ---
>  arch/arm/boot/dts/qcom-sdx55.dtsi | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/qcom-sdx55.dtsi b/arch/arm/boot/dts/qcom-sdx55.dtsi
> index 927f43a7414c..e48ec7a1971b 100644
> --- a/arch/arm/boot/dts/qcom-sdx55.dtsi
> +++ b/arch/arm/boot/dts/qcom-sdx55.dtsi
> @@ -166,6 +166,17 @@ sdhc_1: sdhci@...4000 {
>  			status = "disabled";
>  		};
>  
> +		tcsr_mutex_block: syscon@...0000 {
> +			compatible = "syscon";

It was recently determined that simply "syscon" isn't a valid
compatible.

> +			reg = <0x1f40000 0x20000>;
> +		};
> +
> +		tcsr_mutex: hwlock {
> +			compatible = "qcom,tcsr-mutex";

And in some platforms the tcsr_mutex_block seems to be single use
anyways, so I rewrote this binding a while ago.

So, this will still work in Linux, please update the patch to match the
new binding
(Documentation/devicetree/bindings/hwlock/qcom-hwspinlock.yaml)

Thanks,
Bjorn

> +			syscon = <&tcsr_mutex_block 0 0x1000>;
> +			#hwlock-cells = <1>;
> +		};
> +
>  		pdc: interrupt-controller@...0000 {
>  			compatible = "qcom,sdx55-pdc", "qcom,pdc";
>  			reg = <0x0b210000 0x30000>;
> -- 
> 2.25.1
>