linux-kernel - Re: [PATCH] iommu/amd: Set iommu->int_enabled consistently when interrupts are set up

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <160987442134.30234.7295735708927658122.b4-ty@kernel.org>
Date:   Tue,  5 Jan 2021 22:07:01 +0000
From:   Will Deacon <will@...nel.org>
To:     Borislav Petkov <bp@...en8.de>, iommu@...ts.linux-foundation.org,
        David Woodhouse <dwmw2@...radead.org>
Cc:     catalin.marinas@....com, kernel-team@...roid.com,
        Will Deacon <will@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        lkml <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] iommu/amd: Set iommu->int_enabled consistently when interrupts are set up

On Tue, 05 Jan 2021 01:32:51 +0000, David Woodhouse wrote:
> When I made the INTCAPXT support stop gratuitously pretending to be MSI,
> I missed the fact that iommu_setup_msi() also sets the ->int_enabled
> flag. I missed this in the iommu_setup_intcapxt() code path, which means
> that a resume from suspend will try to allocate the IRQ domains again,
> accidentally re-enabling interrupts as it does, resulting in much sadness.
> 
> Lift out the bit which sets iommu->int_enabled into the iommu_init_irq()
> function which is also where it gets checked.

Applied to arm64 (for-next/iommu/fixes), thanks!

[1/1] iommu/amd: Set iommu->int_enabled consistently when interrupts are set up
      https://git.kernel.org/arm64/c/12bc4570c14e

Cheers,
-- 
Will

https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev