linux-kernel - Re: [PATCH] clocksource: ixp4xx: select TIMER

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdYUS+-Fpxn6TiGNZwq3WRkxdAdxmao9VFMKp+ZiEttc3w@mail.gmail.com>
Date:   Tue, 5 Jan 2021 23:33:48 +0100
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Arnd Bergmann <arnd@...nel.org>
Cc:     Daniel Lezcano <daniel.lezcano@...aro.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Arnd Bergmann <arnd@...db.de>,
        Linus Walleij <linusw@...nel.org>,
        Imre Kaloz <kaloz@...nwrt.org>,
        Krzysztof Halasa <khalasa@...p.pl>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] clocksource: ixp4xx: select TIMER_OF when needed

On Sun, Jan 3, 2021 at 3:00 PM Arnd Bergmann <arnd@...nel.org> wrote:

> From: Arnd Bergmann <arnd@...db.de>
>
> Compile-testing the ixp4xx timer with CONFIG_OF enabled but
> CONFIG_TIMER_OF disabled leads to a harmless warning:
>
> arm-linux-gnueabi-ld: warning: orphan section `__timer_of_table' from `drivers/clocksource/timer-ixp4xx.o' being placed in section `__timer_of_table'
>
> Move the select statement from the platform code into the driver
> so it always gets enabled in configurations that rely on it.
>
> Fixes: 40df14cc5cc0 ("clocksource/drivers/ixp4xx: Add OF initialization support")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

That's a nice fix!
Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

Yours,
Linus Walleij