linux-kernel - Re: [f2fs-dev] [PATCH v2] f2fs: fix null page reference in redirty

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <CACOAw_xXPZm65BD0SAwFECyEMCD0i_g+7mKyd+=Gtm3p-W19og@mail.gmail.com>
Date:   Wed, 6 Jan 2021 08:44:53 +0900
From:   Daeho Jeong <daeho43@...il.com>
To:     Markus Elfring <Markus.Elfring@....de>
Cc:     Daeho Jeong <daehojeong@...gle.com>,
        linux-f2fs-devel@...ts.sourceforge.net,
        kernel-janitors@...r.kernel.org,
        Colin Ian King <colin.king@...onical.com>,
        kernel-team@...roid.com, linux-kernel@...r.kernel.org
Subject: Re: [f2fs-dev] [PATCH v2] f2fs: fix null page reference in redirty_blocks

Got it~

Thanks,

2021년 1월 5일 (화) 오후 9:06, Markus Elfring <Markus.Elfring@....de>님이 작성:
>
> > Fixed null page reference when find_lock_page() fails in
> > redirty_blocks().
>
> I suggest to choose an other imperative wording for this change description.
>
> See also:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=36bbbd0e234d817938bdc52121a0f5473b3e58f5#n89
>
>
> > v2: changed error value and break the loop when error occurs
>
> I propose to use a return statement instead of a break in the second if branch
> for this function implementation.
>
> See also:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?id=36bbbd0e234d817938bdc52121a0f5473b3e58f5#n481
>
> Regards,
> Markus
>
>
> _______________________________________________
> Linux-f2fs-devel mailing list
> Linux-f2fs-devel@...ts.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel