linux-kernel - Re: [External] Re: [PATCH 0/2] IdeaPad platform profile support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 5 Jan 2021 14:24:48 +0800
From:   Jiaxun Yang <jiaxun.yang@...goat.com>
To:     Mark Pearson <markpearson@...ovo.com>,
        Hans de Goede <hdegoede@...hat.com>,
        "Rafael J. Wysocki" <rafael@...nel.org>
Cc:     Platform Driver <platform-driver-x86@...r.kernel.org>,
        "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Len Brown <lenb@...nel.org>,
        Mark Gross <mgross@...ux.intel.com>,
        Ike Panhc <ike.pan@...onical.com>,
        ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [External] Re: [PATCH 0/2] IdeaPad platform profile support

在 2021/1/5 上午5:58, Mark Pearson 写道:
> On 04/01/2021 15:58, Hans de Goede wrote:
>> Hi,
>>
>> On 1/4/21 9:33 PM, Rafael J. Wysocki wrote:
>>> On Mon, Jan 4, 2021 at 3:36 PM Hans de Goede <hdegoede@...hat.com>
>>>   wrote:
>>>> Hi,
>>>>
>>>> On 1/1/21 1:56 PM, Jiaxun Yang wrote:
>>>>> Tested on Lenovo Yoga-14SARE Chinese Edition.
>>>>>
[...]
> Just for my understanding of what happens next....please correct me if I
> have anything wrong:
>
>   - platform_profile gets pulled from ACPI for 5.11
>
>   - platform_profile gets updated to add this data/pointer implementation
> and goes into 5.12.
Hi all,

Another approach could be just let all the patch go through pdx86 tree 
and with
pointer part acked by Rafael as it's unlikely to have merge conflicts.

> Jiaxun, let me know if you're happy with following
> up on that based on Hans suggestions, If you are pushed for time let me
> know and I'll happily help out/implement/test as required. I sadly don't
> have any ideapads but very happy to support your efforts any way I can.


I'm happy with Hans suggestion, will send v2 for it later.

I've been ask Lenovo engineers about DYTC and other ideapad ACPI
stuff on Lenovo China forum[1], but moderator here told me Lenovo won't
invest any Linux effort on their consumer product line :-(

Is it possible to publish a DYTC specification or documents to help us 
further
understand these mechanisms?

I'm tired of reading disassembly AML and code to figure out these internals.

>
>   - Can we get the x86 portion done at the same time or does that end up
> going to 5.13? I had been looking at the ideapad_laptop.c patch and have
> some concerns there as Jiaxun's patch is essentially a duplicate of what
> I implemented in thinkpad_acpi.c which doesn't seem to be ideal
> (especially as there is a V6 version of DYTC coming out this year). I
> haven't had time to look at code to consider better alternatives though...

It may be worthy to share these code but I'm comfort to have this 
duplication as I'm
unsure about the future of DYTC. Will DYTC for thinkpads always coherent 
with DYTC
for ideapads?

Thanks.

[1]: https://club.lenovo.com.cn/thread-5980431-1-1.html

- Jiaxun

>
> Mark