linux-kernel - Re: [PATCH v3 1/2] dt-bindings: spi: Realtek RTL838x/RTL839x SPI controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <121d9dc6-7993-d43b-291f-74dd943f4fc6@biot.com>
Date:   Tue, 5 Jan 2021 09:43:59 +0100
From:   Bert Vermeulen <bert@...t.com>
To:     Mark Brown <broonie@...nel.org>
Cc:     Rob Herring <robh+dt@...nel.org>,
        Birger Koblitz <mail@...ger-koblitz.de>,
        linux-spi@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 1/2] dt-bindings: spi: Realtek RTL838x/RTL839x SPI
 controller

On 1/4/21 10:31 PM, Mark Brown wrote:
> On Fri, Jan 01, 2021 at 02:24:31PM +0100, Bert Vermeulen wrote:
> 
>> +  compatible:
>> +    const: realtek,rtl-spi
> 
> This is still just using rtl-spi as the compatible string, please
> address the feedback on the previous version.

Mark,

The rtl prefix really is as close as it gets. This is being developed on 
RTL838x and RTL839x, but the driver very likely also works on RTL8196C and 
RTL93xx series. There's no difference to the SPI block in those SoCs.

Do you really want a different per-series compatible when the "IP block" was 
just copy-pasted between series in hardware?

-- 
Bert Vermeulen
bert@...t.com