linux-kernel - Re: [PATCH] checkpatch: fix unescaped left braces

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cf102ac77eb1f9e6424f30aef835f6c61dd03407.camel@perches.com>
Date:   Tue, 05 Jan 2021 02:01:09 -0800
From:   Joe Perches <joe@...ches.com>
To:     Dwaipayan Ray <dwaipayanray1@...il.com>
Cc:     linux-kernel-mentees@...ts.linuxfoundation.org,
        linux-kernel@...r.kernel.org, lukas.bulwahn@...il.com
Subject: Re: [PATCH] checkpatch: fix unescaped left braces

On Tue, 2021-01-05 at 15:05 +0530, Dwaipayan Ray wrote:
> Perl 5.22 onwards require that "A literal "{" should now be
> escaped in a pattern".

Not quite correct.

> checkpatch contains several literal "{". Fix such instances
> by preceding them with a backslash.

Not all literal left braces need to be escaped.
https://www.perlmonks.org/?node_id=1191981

> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
> @@ -2036,7 +2036,7 @@ sub annotate_values {
>  			print "ASSIGN($1)\n" if ($dbg_values > 1);
>  			$type = 'N';
>  
> 
> -		} elsif ($cur =~/^(;|{|})/) {
> +		} elsif ($cur =~ /^(;|\{|\})/) {

Like this one.  And why escape the right brace too?

>  			print "END($1)\n" if ($dbg_values > 1);
>  			$type = 'E';
>  			$av_pend_colon = 'O';
> @@ -3913,7 +3913,7 @@ sub process {
>  			# it there is no point in retrying a statement scan
>  			# until we hit end of it.
>  			my $frag = $stat; $frag =~ s/;+\s*$//;
> -			if ($frag !~ /(?:{|;)/) {
> +			if ($frag !~ /(?:\{|;)/) {

And here.

etc...