lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20210105100942.GC2000@ninjato>
Date:   Tue, 5 Jan 2021 11:09:42 +0100
From:   Wolfram Sang <wsa@...nel.org>
To:     trix@...hat.com, Jean Delvare <jdelvare@...e.de>
Cc:     linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] i2c: remove h from printk format specifier

On Tue, Dec 15, 2020 at 10:33:27AM -0800, trix@...hat.com wrote:
> From: Tom Rix <trix@...hat.com>
> 
> See Documentation/core-api/printk-formats.rst.
> h should no longer be used in the format specifier for printk.
> 
> Signed-off-by: Tom Rix <trix@...hat.com>

Adding Jean to CC. Jean, I'd think %02x would be better, what do you
think?

> ---
>  drivers/i2c/i2c-smbus.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/i2c/i2c-smbus.c b/drivers/i2c/i2c-smbus.c
> index d3d06e3b4f3b..5cd2cf84659e 100644
> --- a/drivers/i2c/i2c-smbus.c
> +++ b/drivers/i2c/i2c-smbus.c
> @@ -396,7 +396,7 @@ void i2c_register_spd(struct i2c_adapter *adap)
>  
>  		if (!IS_ERR(i2c_new_scanned_device(adap, &info, addr_list, NULL))) {
>  			dev_info(&adap->dev,
> -				 "Successfully instantiated SPD at 0x%hx\n",
> +				 "Successfully instantiated SPD at 0x%x\n",
>  				 addr_list[0]);
>  			dimm_count--;
>  		}
> -- 
> 2.27.0
> 

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ