linux-kernel - RE: [PATCH] checkpatch: fix unescaped left braces

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <027501cb2506426d9c05adf56d002781@AcuMS.aculab.com>
Date:   Tue, 5 Jan 2021 10:35:31 +0000
From:   David Laight <David.Laight@...LAB.COM>
To:     'Joe Perches' <joe@...ches.com>,
        Dwaipayan Ray <dwaipayanray1@...il.com>
CC:     "linux-kernel-mentees@...ts.linuxfoundation.org" 
        <linux-kernel-mentees@...ts.linuxfoundation.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "lukas.bulwahn@...il.com" <lukas.bulwahn@...il.com>
Subject: RE: [PATCH] checkpatch: fix unescaped left braces

From: Joe Perches
> Sent: 05 January 2021 10:01
> 
> On Tue, 2021-01-05 at 15:05 +0530, Dwaipayan Ray wrote:
> > Perl 5.22 onwards require that "A literal "{" should now be
> > escaped in a pattern".

Sounds like a good reason to never use perl :-)

> Not quite correct.
> 
> > checkpatch contains several literal "{". Fix such instances
> > by preceding them with a backslash.
> 
> Not all literal left braces need to be escaped.
> https://www.perlmonks.org/?node_id=1191981
> 
> > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> []
> > @@ -2036,7 +2036,7 @@ sub annotate_values {
> >  			print "ASSIGN($1)\n" if ($dbg_values > 1);
> >  			$type = 'N';
> >
> >
> > -		} elsif ($cur =~/^(;|{|})/) {
> > +		} elsif ($cur =~ /^(;|\{|\})/) {

isn't (;|{|}) much the same as [;{}] ??

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)