linux-kernel - Re: [PATCH] checkpatch: trivial style fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <834383f004e107752d21ca8331add97808b3719d.camel@perches.com>
Date:   Tue, 05 Jan 2021 02:37:37 -0800
From:   Joe Perches <joe@...ches.com>
To:     Dwaipayan Ray <dwaipayanray1@...il.com>,
        Andrew Morton <akpm@...ux-foundation.org>
Cc:     linux-kernel-mentees@...ts.linuxfoundation.org,
        linux-kernel@...r.kernel.org, lukas.bulwahn@...il.com
Subject: Re: [PATCH] checkpatch: trivial style fixes

On Tue, 2021-01-05 at 16:00 +0530, Dwaipayan Ray wrote:
> Indentations should use tabs wherever possible.
> Replace spaces by tabs for indents.

Thanks.

Acked-by: Joe Perches <joe@...ches.com>

> 
> Signed-off-by: Dwaipayan Ray <dwaipayanray1@...il.com>
> ---
>  scripts/checkpatch.pl | 18 +++++++++---------
>  1 file changed, 9 insertions(+), 9 deletions(-)
> 
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index e6857bdfcb2d..7a323ca8a177 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -2974,7 +2974,7 @@ sub process {
>  				}
>  				if (!defined $lines[$linenr]) {
>  					WARN("BAD_SIGN_OFF",
> -                                             "Co-developed-by: must be immediately followed by Signed-off-by:\n" . "$here\n" . $rawline);
> +					     "Co-developed-by: must be immediately followed by Signed-off-by:\n" . "$here\n" . $rawline);
>  				} elsif ($rawlines[$linenr] !~ /^\s*signed-off-by:\s*(.*)/i) {
>  					WARN("BAD_SIGN_OFF",
>  					     "Co-developed-by: must be immediately followed by Signed-off-by:\n" . "$here\n" . $rawline . "\n" .$rawlines[$linenr]);
> @@ -2997,8 +2997,8 @@ sub process {
>  			if (ERROR("GERRIT_CHANGE_ID",
>  			          "Remove Gerrit Change-Id's before submitting upstream\n" . $herecurr) &&
>  			    $fix) {
> -                                fix_delete_line($fixlinenr, $rawline);
> -                        }
> +				fix_delete_line($fixlinenr, $rawline);
> +			}
>  		}
>  
> 
>  # Check if the commit log is in a possible stack dump
> @@ -3240,10 +3240,10 @@ sub process {
>  				next if ($start_char =~ /^\S$/);
>  				next if (index(" \t.,;?!", $end_char) == -1);
>  
> 
> -                                # avoid repeating hex occurrences like 'ff ff fe 09 ...'
> -                                if ($first =~ /\b[0-9a-f]{2,}\b/i) {
> -                                        next if (!exists($allow_repeated_words{lc($first)}));
> -                                }
> +				# avoid repeating hex occurrences like 'ff ff fe 09 ...'
> +				if ($first =~ /\b[0-9a-f]{2,}\b/i) {
> +					next if (!exists($allow_repeated_words{lc($first)}));
> +				}
>  
> 
>  				if (WARN("REPEATED_WORD",
>  					 "Possible repeated word: '$first'\n" . $herecurr) &&
> @@ -4432,7 +4432,7 @@ sub process {
>  			WARN("STATIC_CONST_CHAR_ARRAY",
>  			     "char * array declaration might be better as static const\n" .
>  				$herecurr);
> -               }
> +		}
>  
> 
>  # check for sizeof(foo)/sizeof(foo[0]) that could be ARRAY_SIZE(foo)
>  		if ($line =~ m@\bsizeof\s*\(\s*($Lval)\s*\)@) {
> @@ -5285,7 +5285,7 @@ sub process {
>  		    $lines[$linenr - 3] !~ /^[ +]\s*$Ident\s*:/) {
>  			WARN("RETURN_VOID",
>  			     "void function return statements are not generally useful\n" . $hereprev);
> -               }
> +		}
>  
> 
>  # if statements using unnecessary parentheses - ie: if ((foo == bar))
>  		if ($perl_version_ok &&