linux-kernel - Re: 回复: KASAN: use-after-free Read in service_outstanding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d09747d30bdb0a79daf9fa4bd381cc8deeb81d50.camel@suse.com>
Date:   Tue, 05 Jan 2021 11:51:31 +0100
From:   Oliver Neukum <oneukum@...e.com>
To:     "Zhang, Qiang" <Qiang.Zhang@...driver.com>,
        syzbot <syzbot+9e04e2df4a32fb661daf@...kaller.appspotmail.com>,
        "andreyknvl@...gle.com" <andreyknvl@...gle.com>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "gustavoars@...nel.org" <gustavoars@...nel.org>,
        "ingrassia@...genesys.com" <ingrassia@...genesys.com>,
        "lee.jones@...aro.org" <lee.jones@...aro.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "penguin-kernel@...ove.SAKURA.ne.jp" 
        <penguin-kernel@...ove.sakura.ne.jp>,
        "syzkaller-bugs@...glegroups.com" <syzkaller-bugs@...glegroups.com>
Subject: Re: 回复: KASAN: use-after-free Read in
 service_outstanding_interrupt

Am Dienstag, den 05.01.2021, 04:50 +0000 schrieb Zhang, Qiang:
> 
> ________________________________________
> 发件人: Oliver Neukum <oneukum@...e.com>
> 发送时间: 2021年1月5日 0:28
> 收件人: syzbot; andreyknvl@...gle.com; gregkh@...uxfoundation.org; gustavoars@...nel.org; ingrassia@...genesys.com; lee.jones@...aro.org; linux-kernel@...r.kernel.org; linux-usb@...r.kernel.org; penguin-kernel@...ove.SAKURA.ne.jp; syzkaller-bugs@...glegroups.com
> 主题: Re: KASAN: use-after-free Read in service_outstanding_interrupt
> 
> Am Donnerstag, den 17.12.2020, 19:21 -0800 schrieb syzbot:
> > syzbot has found a reproducer for the following issue on:
> > 
> > HEAD commit:    5e60366d Merge tag 'fallthrough-fixes-clang-5.11-rc1' of g..
> > git tree:       https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
> > console output: https://syzkaller.appspot.com/x/log.txt?x=12c5b623500000
> > kernel config:  https://syzkaller.appspot.com/x/.config?x=5cea7506b7139727
> > dashboard link: https://syzkaller.appspot.com/bug?extid=9e04e2df4a32fb661daf
> > compiler:       gcc (GCC) 10.1.0-syz 20200507
> > syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=175adf07500000
> > C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=1672680f500000
> > 
> > IMPORTANT: if you fix the issue, please add the following tag to the commit:
> > Reported-by: >syzbot+9e04e2df4a32fb661daf@...kaller.appspotmail.com
> > 
> > #syz test: https://github.com/google/kasan.git  5e60366d
> > 
> 
>  Hello Oliver 
>  
>  this use-after-free still exists，It can be seen from calltrace that it is 
>  usb_device's object  has been released when disconnect,
>  can add a reference count to usb_device's object to avoid this problem 

Hi,

thanks for your analysis. I think you are correct in your analysis, but
I am afraid your fix is not correct. The driver is submitting an URB
to a disconnected device. Your fix would prevent a crash, which is
definitely good, but we still cannot do that, because the device may
be owned by another driver or usbfs at that time.

	Regards
		Oliver