linux-kernel - RE: [PATCH 2/2] soc: ti: pruss: add support for AM18XX/OMAP-L138 PRUSS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <trinity-d842a18b-6a07-4739-a779-e621d6bbca7c-1609855991515@3c-app-gmx-bs20>
Date:   Tue, 5 Jan 2021 15:13:11 +0100
From:   Hans-Frieder Vogt <hfvogt@....net>
To:     david@...hnology.com
Cc:     linux-kernel@...r.kernel.org
Subject: RE: [PATCH 2/2] soc: ti: pruss: add support for AM18XX/OMAP-L138
 PRUSS

Hi David,

since you introduced a configuration parameter which was implicitly true before, the config parameter now needs to be explicitly set to true for all SoCs which have cfg registers (specifically AM33XX and AM57XX), see below.

On Mon, Jan 4, 2021, David Lechner wrote:
> This adds support for the PRUSS found in AM18XX/OMAP-L138. This PRUSS
> doesn't have a CFG register, so that is made optional as selected by
> the device tree compatible string.
>
> ARCH_DAVINCI is added in the Kconfig so that the driver can be selected
> on that platform.
>
> Signed-off-by: David Lechner <david@...hnology.com>

... shortened ...

> @@ -309,19 +313,27 @@ static int pruss_remove(struct platform_device *pdev)
>  }
>
>  /* instance-specific driver private data */
> +static const struct pruss_private_data am18xx_pruss_data = {
> +	.has_no_sharedram = true,
> +};
> +
>  static const struct pruss_private_data am437x_pruss1_data = {
>  	.has_no_sharedram = false,
> +	.has_cfg = true,
>  };
>
>  static const struct pruss_private_data am437x_pruss0_data = {
>  	.has_no_sharedram = true,
> +	.has_cfg = true,
>  };
>
>  static const struct pruss_private_data am65x_j721e_pruss_data = {
>  	.has_core_mux_clock = true,
> +	.has_cfg = true,
>  };
>
>  static const struct of_device_id pruss_of_match[] = {
> +	{ .compatible = "ti,am1806-pruss", .data = &am18xx_pruss_data, },
>  	{ .compatible = "ti,am3356-pruss" },

needs something like:
 	{ .compatible = "ti,am3356-pruss", .data = &am33xx_am57xx_pruss_data, },
 	{ .compatible = "ti,am5728-pruss", .data = &am33xx_am57xx_pruss_data, },
with
 static const struct pruss_private_data am33xx_am57xx_pruss_data = {
	.has_cfg = true,
 };

>  	{ .compatible = "ti,am4376-pruss0", .data = &am437x_pruss0_data, },
>  	{ .compatible = "ti,am4376-pruss1", .data = &am437x_pruss1_data, },

---
Best regards,
Hans-Frieder