linux-kernel - Re: [PATCH 1/4] media: vidtv: Add media controller support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 6 Jan 2021 00:44:35 +0800
From:   kernel test robot <lkp@...el.com>
To:     "Daniel W. S. Almeida" <dwlsalmeida@...il.com>, mchehab@...nel.org,
        hverkuil@...all.nl
Cc:     kbuild-all@...ts.01.org, clang-built-linux@...glegroups.com,
        "Daniel W. S. Almeida" <dwlsalmeida@...il.com>,
        linux-media@...r.kernel.org,
        linux-kernel-mentees@...ts.linuxfoundation.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/4] media: vidtv: Add media controller support

Hi "Daniel,

I love your patch! Yet something to improve:

[auto build test ERROR on linuxtv-media/master]
[also build test ERROR on v5.11-rc2 next-20210104]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Daniel-W-S-Almeida/media-vidtv-add-media-controller-support/20210105-211434
base:   git://linuxtv.org/media_tree.git master
config: arm-randconfig-r021-20210105 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 5c951623bc8965fa1e89660f2f5f4a2944e4981a)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install arm cross compiling tool for clang build
        # apt-get install binutils-arm-linux-gnueabi
        # https://github.com/0day-ci/linux/commit/c06a13465ff899cdd2a6badae988b0f8f157f382
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Daniel-W-S-Almeida/media-vidtv-add-media-controller-support/20210105-211434
        git checkout c06a13465ff899cdd2a6badae988b0f8f157f382
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

>> drivers/media/test-drivers/vidtv/vidtv_bridge.c:527:2: error: implicit declaration of function 'media_device_cleanup' [-Werror,-Wimplicit-function-declaration]
           media_device_cleanup(&dvb->mdev);
           ^
   drivers/media/test-drivers/vidtv/vidtv_bridge.c:527:2: note: did you mean 'media_device_pci_init'?
   include/media/media-device.h:468:20: note: 'media_device_pci_init' declared here
   static inline void media_device_pci_init(struct media_device *mdev,
                      ^
   drivers/media/test-drivers/vidtv/vidtv_bridge.c:527:29: error: no member named 'mdev' in 'struct vidtv_dvb'; did you mean 'pdev'?
           media_device_cleanup(&dvb->mdev);
                                      ^~~~
                                      pdev
   drivers/media/test-drivers/vidtv/vidtv_bridge.h:49:26: note: 'pdev' declared here
           struct platform_device *pdev;
                                   ^
   2 errors generated.


vim +/media_device_cleanup +527 drivers/media/test-drivers/vidtv/vidtv_bridge.c

   522	
   523		dev_info(&pdev->dev, "Successfully initialized vidtv!\n");
   524		return ret;
   525	
   526	err_media_device_register:
 > 527		media_device_cleanup(&dvb->mdev);
   528	err_dvb:
   529		kfree(dvb);
   530		return ret;
   531	}
   532	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (33608 bytes)