linux-kernel - Re: [PATCH v2] scripts/gdb: fix list_for

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <04baeb3e-4b46-ae3a-b4e1-4663d1510b05@amazon.com>
Date:   Tue, 5 Jan 2021 10:51:27 -0600
From:   George Prekas <prekageo@...zon.com>
To:     Jan Kiszka <jan.kiszka@...mens.com>,
        Kieran Bingham <kbingham@...nel.org>
CC:     <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] scripts/gdb: fix list_for_each

On 9/24/2020 9:20 AM, George Prekas wrote:
> If the list is uninitialized (next pointer is NULL), list_for_each gets
> stuck in an infinite loop. Print a message and treat list as empty.
>
> Signed-off-by: George Prekas <prekageo@...zon.com>
> ---
>  scripts/gdb/linux/lists.py | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/scripts/gdb/linux/lists.py b/scripts/gdb/linux/lists.py
> index c487ddf09d38..bae4d70b7eae 100644
> --- a/scripts/gdb/linux/lists.py
> +++ b/scripts/gdb/linux/lists.py
> @@ -27,6 +27,11 @@ def list_for_each(head):
>          raise TypeError("Must be struct list_head not {}"
>                             .format(head.type))
>
> +    if head['next'] == 0:
> +        gdb.write("list_for_each: Uninitialized list '{}' treated as 
> empty\n"
> +                     .format(head.address))
> +        return
> +
>      node = head['next'].dereference()
>      while node.address != head.address:
>          yield node.address

Happy New Year!

Any updates on this?

Thanks,
George