linux-kernel - Re: [PATCH] mm: migrate: initialize err in do_migrate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHbLzkoN3bdnHa-xOmGWQhN+dw7AQtbwygsH=VS5or=QoBk0Jg@mail.gmail.com>
Date:   Tue, 5 Jan 2021 09:14:11 -0800
From:   Yang Shi <shy828301@...il.com>
To:     Jan Stancek <jstancek@...hat.com>
Cc:     Linux MM <linux-mm@...ck.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Zi Yan <ziy@...dia.com>, Jan Kara <jack@...e.cz>,
        Matthew Wilcox <willy@...radead.org>,
        Mel Gorman <mgorman@...e.de>, Michal Hocko <mhocko@...e.com>,
        Song Liu <songliubraving@...com>,
        Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] mm: migrate: initialize err in do_migrate_pages

On Tue, Jan 5, 2021 at 6:14 AM Jan Stancek <jstancek@...hat.com> wrote:
>
> After commit 236c32eb1096 ("mm: migrate: clean up migrate_prep{_local}")',
> do_migrate_pages can return uninitialized variable 'err' (which is
> propagated to user-space as error) when 'from' and 'to' nodesets
> are identical. This can be reproduced with LTP migrate_pages01,
> which calls migrate_pages() with same set for both old/new_nodes.
>
> Add 'err' initialization back.

Thanks for catching this. Acked-by: Yang Shi <shy828301@...il.com>

>
> Fixes: 236c32eb1096 ("mm: migrate: clean up migrate_prep{_local}")
> Cc: Zi Yan <ziy@...dia.com>
> Cc: Yang Shi <shy828301@...il.com>
> Cc: Jan Kara <jack@...e.cz>
> Cc: Matthew Wilcox <willy@...radead.org>
> Cc: Mel Gorman <mgorman@...e.de>
> Cc: Michal Hocko <mhocko@...e.com>
> Cc: Song Liu <songliubraving@...com>
> Cc: Andrew Morton <akpm@...ux-foundation.org>
> Signed-off-by: Jan Stancek <jstancek@...hat.com>
> ---
>  mm/mempolicy.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/mempolicy.c b/mm/mempolicy.c
> index 8cf96bd21341..2c3a86502053 100644
> --- a/mm/mempolicy.c
> +++ b/mm/mempolicy.c
> @@ -1111,7 +1111,7 @@ int do_migrate_pages(struct mm_struct *mm, const nodemask_t *from,
>                      const nodemask_t *to, int flags)
>  {
>         int busy = 0;
> -       int err;
> +       int err = 0;
>         nodemask_t tmp;
>
>         migrate_prep();
> --
> 2.18.1
>