linux-kernel - RE: [PATCH 2/2] platform/chrome: cros_ec_typec: Send mux configuration acknowledgment to EC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 6 Jan 2021 21:17:58 +0000
From:   "Patel, Utkarsh H" <utkarsh.h.patel@...el.com>
To:     Benson Leung <bleung@...gle.com>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "enric.balletbo@...labora.com" <enric.balletbo@...labora.com>,
        "pmalani@...omium.org" <pmalani@...omium.org>,
        "bleung@...omium.org" <bleung@...omium.org>,
        "heikki.krogerus@...ux.intel.com" <heikki.krogerus@...ux.intel.com>,
        "Mani, Rajmohan" <rajmohan.mani@...el.com>
Subject: RE: [PATCH 2/2] platform/chrome: cros_ec_typec: Send mux
 configuration acknowledgment to EC

Hi Benson,

Thank you for applying the patches.

> -----Original Message-----
> From: Benson Leung <bleung@...gle.com>
> Sent: Tuesday, January 05, 2021 2:51 PM
> To: Patel, Utkarsh H <utkarsh.h.patel@...el.com>
> Cc: linux-kernel@...r.kernel.org; enric.balletbo@...labora.com;
> pmalani@...omium.org; bleung@...omium.org;
> heikki.krogerus@...ux.intel.com; Mani, Rajmohan
> <rajmohan.mani@...el.com>
> Subject: Re: [PATCH 2/2] platform/chrome: cros_ec_typec: Send mux
> configuration acknowledgment to EC
> 
> Hi Utkarsh,
> 
> > diff --git a/drivers/platform/chrome/cros_ec_typec.c
> > b/drivers/platform/chrome/cros_ec_typec.c
> > index 650aa5332055..e6abe205890c 100644
> 
> I went ahead and staged this commit, but just for your information, applying
> this patch was problematic because the sha1 used here didn't match anything
> in the upstream kernel.
> 
> Here's the error when I try to apply this using git am:
> Applying: platform/chrome: cros_ec_typec: Send mux configuration
> acknowledgment to EC
> error: sha1 information is lacking or useless
> (drivers/platform/chrome/cros_ec_typec.c).
> error: could not build fake ancestor
> Patch failed at 0001 platform/chrome: cros_ec_typec: Send mux configuration
> acknowledgment to EC
> 
> 
> Please double check when you run git-format-patch that the branch you are
> working on comes from publicly available git repos, ideally, based on linus's
> tagged releases. This will ensure things apply cleanly on my side.

Sorry about this. I think I might have used for-next branch mistakenly when running git-format-patch.
I will make sure to use correct one next time. 

> 
> I've gone ahead and staged this, but could you please sanity check that the
> result is as intended?
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/chrome-
> platform/linux.git/commit/?h=cros-ec-typec-for-
> 5.12&id=8553a979fcd03448a4096c7d431b7ee1a52bfca3

I have checked it on myside and works as intended.

> 
> Thank you,
> Benson
> 

Sincerely,
Utkarsh Patel.