linux-kernel - Re: [PATCH] rxrpc: fix handling of an unsupported token type in rxrpc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8db4e32e-a587-e0ab-d4a6-678cfbc7173e@redhat.com>
Date:   Wed, 6 Jan 2021 14:09:04 -0800
From:   Tom Rix <trix@...hat.com>
To:     David Howells <dhowells@...hat.com>
Cc:     davem@...emloft.net, kuba@...nel.org, natechancellor@...il.com,
        ndesaulniers@...gle.com, linux-afs@...ts.infradead.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        clang-built-linux@...glegroups.com
Subject: Re: [PATCH] rxrpc: fix handling of an unsupported token type in
 rxrpc_read()


On 1/6/21 1:09 PM, David Howells wrote:
> Tom Rix <trix@...hat.com> wrote:
>
>> On 1/6/21 11:44 AM, David Howells wrote:
>>> Tom Rix <trix@...hat.com> wrote:
>>>
>>>> These two loops iterate over the same data, i believe returning here is all
>>>> that is needed.
>>> But if the first loop is made to support a new type, but the second loop is
>>> missed, it will then likely oops.  Besides, the compiler should optimise both
>>> paths together.
>> You are right, I was only considering the existing cases.
> Thanks.  Can I put that down as a Reviewed-by?

Yes, please.

Reviewed-by: Tom Rix <trix@...hat.com>

>
> David
>