linux-kernel - Re: [PATCH] MIPS: c-r4k: Fix section mismatch for loongson2_sc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 6 Jan 2021 08:27:22 +0800
From:   Huacai Chen <chenhuacai@...nel.org>
To:     Nathan Chancellor <natechancellor@...il.com>
Cc:     Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        "open list:MIPS" <linux-mips@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        clang-built-linux@...glegroups.com
Subject: Re: [PATCH] MIPS: c-r4k: Fix section mismatch for loongson2_sc_init

Reviewed-by: Huacai Chen <chenhuacai@...nel.org>

On Wed, Jan 6, 2021 at 7:01 AM Nathan Chancellor
<natechancellor@...il.com> wrote:
>
> When building with clang, the following section mismatch warning occurs:
>
> WARNING: modpost: vmlinux.o(.text+0x24490): Section mismatch in
> reference from the function r4k_cache_init() to the function
> .init.text:loongson2_sc_init()
>
> This should have been fixed with commit ad4fddef5f23 ("mips: fix Section
> mismatch in reference") but it was missed. Remove the improper __init
> annotation like that commit did.
>
> Fixes: 078a55fc824c ("MIPS: Delete __cpuinit/__CPUINIT usage from MIPS code")
> Link: https://github.com/ClangBuiltLinux/linux/issues/787
> Signed-off-by: Nathan Chancellor <natechancellor@...il.com>
> ---
>  arch/mips/mm/c-r4k.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/mips/mm/c-r4k.c b/arch/mips/mm/c-r4k.c
> index 4f976d687ab0..f67297b3175f 100644
> --- a/arch/mips/mm/c-r4k.c
> +++ b/arch/mips/mm/c-r4k.c
> @@ -1593,7 +1593,7 @@ static int probe_scache(void)
>         return 1;
>  }
>
> -static void __init loongson2_sc_init(void)
> +static void loongson2_sc_init(void)
>  {
>         struct cpuinfo_mips *c = &current_cpu_data;
>
>
> base-commit: 36bbbd0e234d817938bdc52121a0f5473b3e58f5
> --
> 2.30.0
>