linux-kernel - Re: [PATCH v2] binfmt_elf: Fix fill_prstatus() call in fill_note

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210106134428.GB3579531@ZenIV.linux.org.uk>
Date:   Wed, 6 Jan 2021 13:44:28 +0000
From:   Al Viro <viro@...iv.linux.org.uk>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:     linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] binfmt_elf: Fix fill_prstatus() call in
 fill_note_info()

On Wed, Jan 06, 2021 at 08:51:12AM +0100, Geert Uytterhoeven wrote:
> On m68k, which does not define CORE_DUMP_USE_REGSET:
> 
>     fs/binfmt_elf.c: In function ‘fill_note_info’:
>     fs/binfmt_elf.c:2040:20: error: passing argument 1 of ‘fill_prstatus’ from incompatible pointer type [-Werror=incompatible-pointer-types]
>      2040 |  fill_prstatus(info->prstatus, current, siginfo->si_signo);
> 	  |                ~~~~^~~~~~~~~~
> 	  |                    |
> 	  |                    struct elf_prstatus *
>     fs/binfmt_elf.c:1498:55: note: expected ‘struct elf_prstatus_common *’ but argument is of type ‘struct elf_prstatus *’
>      1498 | static void fill_prstatus(struct elf_prstatus_common *prstatus,
> 	  |                           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~
> 
> The fill_prstatus() signature was changed, but one caller was not
> updated.
> 
> Reported-by: noreply@...erman.id.au
> Fixes: 147d88b334cd5416 ("elf_prstatus: collect the common part (everything before pr_reg) into a struct")
> Signed-off-by: Geert Uytterhoeven <geert@...ux-m68k.org>
> ---
> Compile-tested only.  Feel free to fold into the original commit.

Thanks, folded and pushed out...