linux-kernel - Re: [PATCH -next] media: atomisp: use resource

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 6 Jan 2021 14:47:32 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Zheng Yongjun <zhengyongjun3@...wei.com>
Cc:     mchehab@...nel.org, linux-media@...r.kernel.org,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
        sakari.ailus@...ux.intel.com
Subject: Re: [PATCH -next] media: atomisp: use resource_size

On Wed, Jan 06, 2021 at 09:17:37PM +0800, Zheng Yongjun wrote:
> Use resource_size rather than a verbose computation on
> the end and start fields.
> 
> Signed-off-by: Zheng Yongjun <zhengyongjun3@...wei.com>
> ---
>  drivers/staging/media/atomisp/pci/sh_css_params.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/media/atomisp/pci/sh_css_params.c b/drivers/staging/media/atomisp/pci/sh_css_params.c
> index 24fc497bd491..4a02948e5612 100644
> --- a/drivers/staging/media/atomisp/pci/sh_css_params.c
> +++ b/drivers/staging/media/atomisp/pci/sh_css_params.c
> @@ -949,7 +949,7 @@ sh_css_set_black_frame(struct ia_css_stream *stream,
>  
>  	params = stream->isp_params_configs;
>  	height = raw_black_frame->info.res.height;
> -	width = raw_black_frame->info.padded_width,
> +	width = raw_black_frame->info.padded_width;
d>  
>  	ptr = raw_black_frame->data
>  	+ raw_black_frame->planes.raw.offset;
> @@ -1443,7 +1443,7 @@ static int sh_css_params_default_morph_table(
>  	IA_CSS_ENTER_PRIVATE("");
>  
>  	step = (ISP_VEC_NELEMS / 16) * 128,
> -	width = binary->morph_tbl_width,
> +	width = binary->morph_tbl_width;
>  	height = binary->morph_tbl_height;
>  
>  	tab = ia_css_morph_table_allocate(width, height);
> -- 
> 2.22.0
> 

Your description does not match what the patch does at all :(