linux-kernel - Re: [PATCH -next] mfd: use resource

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 6 Jan 2021 13:53:27 +0000
From:   Lee Jones <lee.jones@...aro.org>
To:     Zheng Yongjun <zhengyongjun3@...wei.com>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] mfd: use resource_size

Please fix your subject line to match the others in the subsystem.

`git log --oneline -- drivers/<subsystem>` is your friend.

On Wed, 06 Jan 2021, Zheng Yongjun wrote:

> Use resource_size rather than a verbose computation on
> the end and start fields.

Not sure I can see how this matches to the diff below?

Please could you provide more detail?

> Signed-off-by: Zheng Yongjun <zhengyongjun3@...wei.com>
> ---
>  drivers/mfd/88pm860x-core.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/mfd/88pm860x-core.c b/drivers/mfd/88pm860x-core.c
> index c9bae71f643a..a9e0855b4c66 100644
> --- a/drivers/mfd/88pm860x-core.c
> +++ b/drivers/mfd/88pm860x-core.c
> @@ -916,7 +916,7 @@ static void device_power_init(struct pm860x_chip *chip,
>  	power_devs[0].platform_data = pdata->power;
>  	power_devs[0].pdata_size = sizeof(struct pm860x_power_pdata);
>  	power_devs[0].num_resources = ARRAY_SIZE(battery_resources);
> -	power_devs[0].resources = &battery_resources[0],
> +	power_devs[0].resources = &battery_resources[0];
>  	ret = mfd_add_devices(chip->dev, 0, &power_devs[0], 1,
>  			      &battery_resources[0], chip->irq_base, NULL);
>  	if (ret < 0)
> @@ -925,7 +925,7 @@ static void device_power_init(struct pm860x_chip *chip,
>  	power_devs[1].platform_data = pdata->power;
>  	power_devs[1].pdata_size = sizeof(struct pm860x_power_pdata);
>  	power_devs[1].num_resources = ARRAY_SIZE(charger_resources);
> -	power_devs[1].resources = &charger_resources[0],
> +	power_devs[1].resources = &charger_resources[0];
>  	ret = mfd_add_devices(chip->dev, 0, &power_devs[1], 1,
>  			      &charger_resources[0], chip->irq_base, NULL);
>  	if (ret < 0)
> @@ -942,7 +942,7 @@ static void device_power_init(struct pm860x_chip *chip,
>  		pdata->chg_desc->charger_regulators =
>  			&chg_desc_regulator_data[0];
>  		pdata->chg_desc->num_charger_regulators	=
> -			ARRAY_SIZE(chg_desc_regulator_data),
> +			ARRAY_SIZE(chg_desc_regulator_data);
>  		power_devs[3].platform_data = pdata->chg_desc;
>  		power_devs[3].pdata_size = sizeof(*pdata->chg_desc);
>  		ret = mfd_add_devices(chip->dev, 0, &power_devs[3], 1,
> @@ -958,7 +958,7 @@ static void device_onkey_init(struct pm860x_chip *chip,
>  	int ret;
>  
>  	onkey_devs[0].num_resources = ARRAY_SIZE(onkey_resources);
> -	onkey_devs[0].resources = &onkey_resources[0],
> +	onkey_devs[0].resources = &onkey_resources[0];
>  	ret = mfd_add_devices(chip->dev, 0, &onkey_devs[0],
>  			      ARRAY_SIZE(onkey_devs), &onkey_resources[0],
>  			      chip->irq_base, NULL);
> @@ -972,7 +972,7 @@ static void device_codec_init(struct pm860x_chip *chip,
>  	int ret;
>  
>  	codec_devs[0].num_resources = ARRAY_SIZE(codec_resources);
> -	codec_devs[0].resources = &codec_resources[0],
> +	codec_devs[0].resources = &codec_resources[0];
>  	ret = mfd_add_devices(chip->dev, 0, &codec_devs[0],
>  			      ARRAY_SIZE(codec_devs), &codec_resources[0], 0,
>  			      NULL);

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog