linux-kernel - Re: [PATCH] ptp: ptp_ines: prevent build when HAS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210106144636.GB10150@hoboy.vegasvil.org>
Date:   Wed, 6 Jan 2021 06:46:36 -0800
From:   Richard Cochran <richardcochran@...il.com>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     linux-kernel@...r.kernel.org, kernel test robot <lkp@...el.com>,
        netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>
Subject: Re: [PATCH] ptp: ptp_ines: prevent build when HAS_IOMEM is not set

On Tue, Jan 05, 2021 at 08:25:31PM -0800, Randy Dunlap wrote:
> ptp_ines.c uses devm_platform_ioremap_resource(), which is only
> built/available when CONFIG_HAS_IOMEM is enabled.
> CONFIG_HAS_IOMEM is not enabled for arch/s390/, so builds on S390
> have a build error:
> 
> s390-linux-ld: drivers/ptp/ptp_ines.o: in function `ines_ptp_ctrl_probe':
> ptp_ines.c:(.text+0x17e6): undefined reference to `devm_platform_ioremap_resource'
> 
> Prevent builds of ptp_ines.c when HAS_IOMEM is not set.

Acked-by: Richard Cochran <richardcochran@...il.com>