linux-kernel - Re: [PATCH -next] mtd: use resource

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210106154954.4f85ed76@xps13>
Date:   Wed, 6 Jan 2021 15:49:54 +0100
From:   Miquel Raynal <miquel.raynal@...tlin.com>
To:     Zheng Yongjun <zhengyongjun3@...wei.com>
Cc:     <richard@....at>, <vigneshr@...com>,
        <linux-mtd@...ts.infradead.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next] mtd: use resource_size

Hello,

Zheng Yongjun <zhengyongjun3@...wei.com> wrote on Wed, 6 Jan 2021
21:18:31 +0800:

> Use resource_size rather than a verbose computation on
> the end and start fields.

The commit message and the patch content do not match.
  
> 
> Signed-off-by: Zheng Yongjun <zhengyongjun3@...wei.com>
> ---
>  drivers/mtd/maps/pci.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/mtd/maps/pci.c b/drivers/mtd/maps/pci.c
> index 377ef0fc4e3e..ca00d211e73e 100644
> --- a/drivers/mtd/maps/pci.c
> +++ b/drivers/mtd/maps/pci.c
> @@ -90,8 +90,8 @@ intel_iq80310_init(struct pci_dev *dev, struct map_pci_info *map)
>  	u32 win_base;
>  
>  	map->map.bankwidth = 1;
> -	map->map.read = mtd_pci_read8,
> -	map->map.write = mtd_pci_write8,
> +	map->map.read = mtd_pci_read8;
> +	map->map.write = mtd_pci_write8;
>  
>  	map->map.size     = 0x00800000;
>  	map->base         = ioremap(pci_resource_start(dev, 0),
> @@ -185,8 +185,8 @@ intel_dc21285_init(struct pci_dev *dev, struct map_pci_info *map)
>  		return -ENXIO;
>  
>  	map->map.bankwidth = 4;
> -	map->map.read = mtd_pci_read32,
> -	map->map.write = mtd_pci_write32,
> +	map->map.read = mtd_pci_read32;
> +	map->map.write = mtd_pci_write32;
>  	map->map.size     = len;
>  	map->base         = ioremap(base, len);
>  

Thanks,
Miquèl