linux-kernel - Re: [PATCH -next] mtd: st_spi_fsm: use resource

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210106155133.7f901871@xps13>
Date:   Wed, 6 Jan 2021 15:51:33 +0100
From:   Miquel Raynal <miquel.raynal@...tlin.com>
To:     Zheng Yongjun <zhengyongjun3@...wei.com>
Cc:     <richard@....at>, <vigneshr@...com>,
        <linux-mtd@...ts.infradead.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next] mtd: st_spi_fsm: use resource_size

Hello,

Zheng Yongjun <zhengyongjun3@...wei.com> wrote on Wed, 6 Jan 2021
21:18:47 +0800:

> Use resource_size rather than a verbose computation on
> the end and start fields.
> 
> Signed-off-by: Zheng Yongjun <zhengyongjun3@...wei.com>
> ---
>  drivers/mtd/devices/st_spi_fsm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mtd/devices/st_spi_fsm.c b/drivers/mtd/devices/st_spi_fsm.c
> index 1888523d9745..983999c020d6 100644
> --- a/drivers/mtd/devices/st_spi_fsm.c
> +++ b/drivers/mtd/devices/st_spi_fsm.c
> @@ -924,7 +924,7 @@ static int stfsm_read_status(struct stfsm *fsm, uint8_t cmd,
>  	BUG_ON(bytes != 1 && bytes != 2);
>  
>  	seq->seq_opc[0] = (SEQ_OPC_PADS_1 | SEQ_OPC_CYCLES(8) |
> -			   SEQ_OPC_OPCODE(cmd)),
> +			   SEQ_OPC_OPCODE(cmd));
>  
>  	stfsm_load_seq(fsm, seq);
>  

Same remark again, description and actual change do not match.

Thanks,
Miquèl