linux-kernel - Re: [PATCH net-next] net: broadcom: Drop OF dependency from BGMAC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <90e88bac-9ed3-4a96-605e-b4457b3103d2@infradead.org>
Date:   Wed, 6 Jan 2021 11:27:29 -0800
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Florian Fainelli <f.fainelli@...il.com>, netdev@...r.kernel.org
Cc:     "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Masahiro Yamada <masahiroy@...nel.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next] net: broadcom: Drop OF dependency from
 BGMAC_PLATFORM

On 1/6/21 11:15 AM, Florian Fainelli wrote:
> All of the OF code that is used has stubbed and will compile and link
> just fine, keeping COMPILE_TEST is enough.

Yes, that matches my understanding.

I wish we had a list of which API families have full stub support...

Acked-by: Randy Dunlap <rdunlap@...radead.org>

Thanks.

> Signed-off-by: Florian Fainelli <f.fainelli@...il.com>
> ---
>  drivers/net/ethernet/broadcom/Kconfig | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/broadcom/Kconfig b/drivers/net/ethernet/broadcom/Kconfig
> index 7b79528d6eed..4bdf8fbe75a6 100644
> --- a/drivers/net/ethernet/broadcom/Kconfig
> +++ b/drivers/net/ethernet/broadcom/Kconfig
> @@ -174,7 +174,6 @@ config BGMAC_BCMA
>  config BGMAC_PLATFORM
>  	tristate "Broadcom iProc GBit platform support"
>  	depends on ARCH_BCM_IPROC || COMPILE_TEST
> -	depends on OF
>  	select BGMAC
>  	select PHYLIB
>  	select FIXED_PHY
> 


-- 
~Randy