lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 07 Jan 2021 19:05:53 +0100 From: Takashi Iwai <tiwai@...e.de> To: Joe Perches <joe@...ches.com> Cc: Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>, LKML <linux-kernel@...r.kernel.org>, kernel-janitors <kernel-janitors@...r.kernel.org>, Julia Lawall <Julia.Lawall@...ia.fr>, alsa-devel <alsa-devel@...a-project.org> Subject: Re: [PATCH resend] sound: Convert strlcpy to strscpy when return value is unused On Mon, 04 Jan 2021 18:17:34 +0100, Joe Perches wrote: > > strlcpy is deprecated. see: Documentation/process/deprecated.rst > > Change the calls that do not use the strlcpy return value to the > preferred strscpy. > > Done with cocci script: > > @@ > expression e1, e2, e3; > @@ > > - strlcpy( > + strscpy( > e1, e2, e3); > > This cocci script leaves the instances where the return value is > used unchanged. > > After this patch, sound/ has 3 uses of strlcpy() that need to be > manually inspected for conversion and changed one day. > > $ git grep -w strlcpy sound/ > sound/usb/card.c: len = strlcpy(card->longname, s, sizeof(card->longname)); > sound/usb/mixer.c: return strlcpy(buf, p->name, buflen); > sound/usb/mixer.c: return strlcpy(buf, p->names[index], buflen); > > Miscellenea: > > o Remove trailing whitespace in conversion of sound/core/hwdep.c > > Link: https://lore.kernel.org/lkml/CAHk-=wgfRnXz0W3D37d01q3JFkr_i_uTL=V6A6G1oUZcprmknw@mail.gmail.com/ > > Signed-off-by: Joe Perches <joe@...ches.com> Applied now. Thanks. Takashi
Powered by blists - more mailing lists