linux-kernel - Re: [PATCH] usb: dwc3: Replace of_reset_control_array

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <49ee0444-4e0f-1dbe-c59a-74c72b34b140@gmail.com>
Date:   Thu, 7 Jan 2021 22:33:00 +0300
From:   Dmitry Osipenko <digetx@...il.com>
To:     Yejune Deng <yejune.deng@...il.com>, balbi@...nel.org,
        gregkh@...uxfoundation.org, p.zabel@...gutronix.de
Cc:     linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] usb: dwc3: Replace of_reset_control_array_get()

03.11.2020 12:25, Yejune Deng пишет:
> of_reset_control_array_get_optional_exclusive() looks more readable
> 
> Signed-off-by: Yejune Deng <yejune.deng@...il.com>
> ---
>  drivers/usb/dwc3/dwc3-of-simple.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/usb/dwc3/dwc3-of-simple.c b/drivers/usb/dwc3/dwc3-of-simple.c
> index e62ecd2..e358ff0 100644
> --- a/drivers/usb/dwc3/dwc3-of-simple.c
> +++ b/drivers/usb/dwc3/dwc3-of-simple.c
> @@ -52,8 +52,7 @@ static int dwc3_of_simple_probe(struct platform_device *pdev)
>  	if (of_device_is_compatible(np, "rockchip,rk3399-dwc3"))
>  		simple->need_reset = true;
>  
> -	simple->resets = of_reset_control_array_get(np, false, true,
> -						    true);
> +	simple->resets = of_reset_control_array_get_optional_exclusive(np);
>  	if (IS_ERR(simple->resets)) {
>  		ret = PTR_ERR(simple->resets);
>  		dev_err(dev, "failed to get device resets, err=%d\n", ret);
> 

Reviewed-by: Dmitry Osipenko <digetx@...il.com>