linux-kernel - Re: [PATCH] x86/resctrl: add printf attribute to log function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <25b32e4b-72c6-bf66-5088-7851b237329f@intel.com>
Date:   Thu, 7 Jan 2021 13:51:59 -0800
From:   Reinette Chatre <reinette.chatre@...el.com>
To:     trix@...hat.com, fenghua.yu@...el.com, tglx@...utronix.de,
        mingo@...hat.com, bp@...en8.de, hpa@...or.com
Cc:     x86@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86/resctrl: add printf attribute to log function

Hi Tom,

On 12/21/2020 8:00 AM, trix@...hat.com wrote:
> From: Tom Rix <trix@...hat.com>
> 
> Attributing the function allows the compiler to more thoroughly
> check the use of the function with -Wformat and similar flags.
> 
> Signed-off-by: Tom Rix <trix@...hat.com>
> ---
>   arch/x86/kernel/cpu/resctrl/internal.h | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/arch/x86/kernel/cpu/resctrl/internal.h b/arch/x86/kernel/cpu/resctrl/internal.h
> index ee71c47844cb..c4d320d02fd5 100644
> --- a/arch/x86/kernel/cpu/resctrl/internal.h
> +++ b/arch/x86/kernel/cpu/resctrl/internal.h
> @@ -572,6 +572,7 @@ union cpuid_0x10_x_edx {
>   
>   void rdt_last_cmd_clear(void);
>   void rdt_last_cmd_puts(const char *s);
> +__printf(1, 2)
>   void rdt_last_cmd_printf(const char *fmt, ...);
>   
>   void rdt_ctrl_update(void *arg);
> 

This is a valuable addition, thank you.

Acked-by: Reinette Chatre <reinette.chatre@...el.com>

Reinette