lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 7 Jan 2021 14:29:14 -0800 From: Reinette Chatre <reinette.chatre@...el.com> To: zhouchuangao <chuangaozhou@...il.com>, fenghua.yu@...el.com, tglx@...utronix.de, mingo@...hat.com, bp@...en8.de, x86@...nel.org Cc: hpa@...or.com, linux-kernel@...r.kernel.org, zhouchuangao <zhouchuangao@...omi.com> Subject: Re: [PATCH] x86/kernel/cpu/resctrl: replace 'of->kn->priv' with of_rft() Hi, On 1/4/2021 3:08 AM, zhouchuangao wrote: > The use of 'of->kn->priv' to get rftype can be found in several > places in arch/x86/kernel/cpu/resctrl/rdtgroup.c, which may reduce > readability. > > So replace the direct use 'of->kn->priv' with inline function > of_rft(), which is more readable. Readability can be subjective. The current assignment appears succinct and in my opinion the additional layer of indirection does not improve the readability. Reinette
Powered by blists - more mailing lists