linux-kernel - Re: [PATCH v1] driver core: Fix device link device name collision

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGETcx87ck19S0UQwdzLPBxGFns6hJbUX4HbfcOkA_MJy=t-8Q@mail.gmail.com>
Date:   Thu, 7 Jan 2021 15:19:38 -0800
From:   Saravana Kannan <saravanak@...gle.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     "Rafael J. Wysocki" <rafael@...nel.org>,
        Michael Walle <michael@...le.cc>,
        Android Kernel Team <kernel-team@...roid.com>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v1] driver core: Fix device link device name collision

On Thu, Jan 7, 2021 at 3:17 PM Saravana Kannan <saravanak@...gle.com> wrote:
>
> On Thu, Jan 7, 2021 at 12:59 AM Greg Kroah-Hartman
> <gregkh@...uxfoundation.org> wrote:
> >
> > On Wed, Jan 06, 2021 at 03:26:41PM -0800, Saravana Kannan wrote:
> > > The device link device's name was of the form:
> > > <supplier-dev-name>--<consumer-dev-name>
> > >
> > > This can cause name collision as reported here [1] as device names are
> > > not globally unique. Since device names have to be unique within the
> > > bus/class, add the bus/class name as a prefix to the device names used to
> > > construct the device link device name.
> > >
> > > So the devuce link device's name will be of the form:
> > > <supplier-bus-name>:<supplier-dev-name>--<consumer-bus-name><consumer-dev-name>
> >
> > Minor nit, you forgot a ':' in the consumer side of the link here.  The
> > code is correct.
>
> Greg,
>
> Do you want me to send a v2 to fix this and add "fixes"? Or will you
> just fix it up when picking it up?
>

Actually, let me send a v2. There's another collision in the symlink's name.

-Saravana