linux-kernel - Re: [PATCH] drm/panel: feiyang-fy07024di26a30d: cleanup if panel attaching failed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <C1F366E9-0EDB-4679-BB93-92223F5B8C4A@aosc.io>
Date:   Thu, 07 Jan 2021 12:00:21 +0800
From:   Icenowy Zheng <icenowy@...c.io>
To:     Jagan Teki <jagan@...rulasolutions.com>
CC:     Thierry Reding <thierry.reding@...il.com>,
        Sam Ravnborg <sam@...nborg.org>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        dri-devel <dri-devel@...ts.freedesktop.org>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drm/panel: feiyang-fy07024di26a30d: cleanup if panel attaching failed



于 2021年1月6日 GMT+08:00 下午5:47:20, Jagan Teki <jagan@...rulasolutions.com> 写到:
>On Sat, Nov 28, 2020 at 6:23 PM Icenowy Zheng <icenowy@...c.io> wrote:
>>
>> Attaching the panel can fail, so cleanup work is necessary, otherwise
>> a pointer to freed struct drm_panel* will remain in drm_panel code.
>>
>> Do the cleanup if panel attaching failed.
>>
>> Fixes: 69dc678abc2b ("drm/panel: Add Feiyang FY07024DI26A30-D
>MIPI-DSI LCD panel")
>
>The fact that this has failed to probe due to recent changes in
>sun6i_mipi_dsi.c I don't know how to put that into the commit message.

It's not related, we shouldn't assume this panel driver will always
be used with sunxi SoCs.

It's a panel driver bug that cannot deal with -EPROBE_DEFER well.

>> Signed-off-by: Icenowy Zheng <icenowy@...c.io>
>> ---
>
>Reviewed-by: Jagan Teki <jagan@...rulasolutions.com>