linux-kernel - RE: [PATCH] exfat: improve performance of exfat_free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <244001d6e4bd$a18072f0$e48158d0$@samsung.com>
Date:   Thu, 7 Jan 2021 15:23:36 +0900
From:   "Sungjong Seo" <sj1557.seo@...sung.com>
To:     "'Hyeongseok Kim'" <hyeongseok@...il.com>,
        <namjae.jeon@...sung.com>
Cc:     <linux-fsdevel@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] exfat: improve performance of exfat_free_cluster when
 using dirsync mount option

> There are stressful update of cluster allocation bitmap when using dirsync
> mount option which is doing sync buffer on every cluster bit clearing.
> This could result in performance degradation when deleting big size file.
> Fix to update only when the bitmap buffer index is changed would make less
> disk access, improving performance especially for truncate operation.
> 
> Testing with Samsung 256GB sdcard, mounted with dirsync option (mount -t
> exfat /dev/block/mmcblk0p1 /temp/mount -o dirsync)
> 
> Remove 4GB file, blktrace result.
> [Before] : 39 secs.
> Total (blktrace):
>  Reads Queued:      0,        0KiB	 Writes Queued:      32775,
16387KiB
>  Read Dispatches:   0,        0KiB	 Write Dispatches:   32775,
16387KiB
>  Reads Requeued:    0		         Writes Requeued:        0
>  Reads Completed:   0,        0KiB	 Writes Completed:   32775,
16387KiB
>  Read Merges:       0,        0KiB	 Write Merges:           0,
0KiB
>  IO unplugs:        2        	     Timer unplugs:          0
> 
> [After] : 1 sec.
> Total (blktrace):
>  Reads Queued:      0,        0KiB	 Writes Queued:         13,
6KiB
>  Read Dispatches:   0,        0KiB	 Write Dispatches:      13,
6KiB
>  Reads Requeued:    0		         Writes Requeued:        0
>  Reads Completed:   0,        0KiB	 Writes Completed:      13,
6KiB
>  Read Merges:       0,        0KiB	 Write Merges:           0,
0KiB
>  IO unplugs:        1        	     Timer unplugs:          0
> 
> Signed-off-by: Hyeongseok Kim <hyeongseok@...il.com>

Looks good.
Thanks for your work!

Acked-by: Sungjong Seo <sj1557.seo@...sung.com>