[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20210107064046.GF28365@dragon>
Date: Thu, 7 Jan 2021 14:40:47 +0800
From: Shawn Guo <shawnguo@...nel.org>
To: Michael Walle <michael@...le.cc>
Cc: linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, Li Yang <leoyang.li@....com>,
Sudhanshu Gupta <sudhanshu.gupta@....com>,
Bhaskar Upadhaya <bhaskar.upadhaya@....com>,
Rai Harninder <harninder.rai@....com>
Subject: Re: [PATCH] arm64: dts: ls1028a: fix the offset of the reset register
On Tue, Dec 15, 2020 at 10:26:22PM +0100, Michael Walle wrote:
> The offset of the reset request register is 0, the absolute address is
> 0x1e60000. Boards without PSCI support will fail to perform a reset:
>
> [ 26.734700] reboot: Restarting system
> [ 27.743259] Unable to restart system
> [ 27.746845] Reboot failed -- System halted
>
> Fixes: 8897f3255c9c ("arm64: dts: Add support for NXP LS1028A SoC")
> Signed-off-by: Michael Walle <michael@...le.cc>
Out of curiosity, how did you get it fixed with your commit 3f0fb37b22b4
("arm64: dts: ls1028a: fix reboot node") in the first place?
Shawn
> ---
> arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> index 045739dbcb17..0a5923e96d7f 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> @@ -102,7 +102,7 @@
> reboot {
> compatible ="syscon-reboot";
> regmap = <&rst>;
> - offset = <0xb0>;
> + offset = <0>;
> mask = <0x02>;
> };
>
> --
> 2.20.1
>
Powered by blists - more mailing lists