linux-kernel - Re: [PATCH] arm64: dts: ls1028a: fix the offset of the reset register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <502fecda4d7f0d85e3417d16748e22f5@walle.cc>
Date:   Thu, 07 Jan 2021 08:53:14 +0100
From:   Michael Walle <michael@...le.cc>
To:     Shawn Guo <shawnguo@...nel.org>
Cc:     linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, Li Yang <leoyang.li@....com>,
        Sudhanshu Gupta <sudhanshu.gupta@....com>,
        Bhaskar Upadhaya <bhaskar.upadhaya@....com>,
        Rai Harninder <harninder.rai@....com>
Subject: Re: [PATCH] arm64: dts: ls1028a: fix the offset of the reset register

Hi Shawn,

Am 2021-01-07 07:40, schrieb Shawn Guo:
> On Tue, Dec 15, 2020 at 10:26:22PM +0100, Michael Walle wrote:
>> The offset of the reset request register is 0, the absolute address is
>> 0x1e60000. Boards without PSCI support will fail to perform a reset:
>> 
>> [   26.734700] reboot: Restarting system
>> [   27.743259] Unable to restart system
>> [   27.746845] Reboot failed -- System halted
>> 
>> Fixes: 8897f3255c9c ("arm64: dts: Add support for NXP LS1028A SoC")
>> Signed-off-by: Michael Walle <michael@...le.cc>
> 
> Out of curiosity, how did you get it fixed with your commit 
> 3f0fb37b22b4
> ("arm64: dts: ls1028a: fix reboot node") in the first place?

I simply must have missed it. There is also a fallback reset method
via the watchdog in the chain, which kicks in if this wasn't successful.
So if you test it, it is easy to think its working although its not.

-michael