linux-kernel - Re: [PATCH] uio: uio_pci_generic: don't fail probe if pdev->irq equals to IRQ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <X/bUA2li9RyoFN7P@kroah.com>
Date:   Thu, 7 Jan 2021 10:27:31 +0100
From:   "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
To:     李捷 <jie6.li@...sung.com>
Cc:     "mst@...hat.com" <mst@...hat.com>,
        "kvm@...r.kernel.org" <kvm@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        김경산 <ks0204.kim@...sung.com>,
        何兴 <xing84.he@...sung.com>,
        吕高飞 <gaofei.lv@...sung.com>
Subject: Re: [PATCH] uio: uio_pci_generic: don't fail probe if pdev->irq
 equals to IRQ_NOTCONNECTED

On Thu, Jan 07, 2021 at 03:50:37PM +0800, 李捷 wrote:
> From 0fbcd7e386898d829d3000d094358a91e626ee4a Mon Sep 17 00:00:00 2001
> From: Jie Li <jie6.li@...sung.com>
> Date: Mon, 7 Dec 2020 08:05:07 +0800
> Subject: [PATCH] uio: uio_pci_generic: don't fail probe if pdev->irq equals to
>  IRQ_NOTCONNECTED
> 
> Some devices use 255 as default value of Interrupt Line register, and this
> maybe causes pdev->irq is set as IRQ_NOTCONNECTED in some scenarios. For
> example, NVMe controller connects to Intel Volume Management Device (VMD).
> In this situation, IRQ_NOTCONNECTED means INTx line is not connected, not
> fault. If bind uio_pci_generic to these devices, uio frame will return
> -ENOTCONN through request_irq.
> 
> This patch allows binding uio_pci_generic to device with dev->irq of
> IRQ_NOTCONNECTED.
> 
> Signed-off-by: Jie Li <jie6.li@...sung.com>
> Acked-by: Kyungsan Kim <ks0204.kim@...sung.com>
> ---
>  drivers/uio/uio_pci_generic.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/uio/uio_pci_generic.c b/drivers/uio/uio_pci_generic.c
> index b8e44d16279f..c7d681fef198 100644
> --- a/drivers/uio/uio_pci_generic.c
> +++ b/drivers/uio/uio_pci_generic.c
> @@ -92,7 +92,7 @@ static int probe(struct pci_dev *pdev,
>         gdev->info.version = DRIVER_VERSION;
>         gdev->info.release = release;
>         gdev->pdev = pdev;
> -       if (pdev->irq) {
> +       if (pdev->irq && (pdev->irq != IRQ_NOTCONNECTED)) {
>                 gdev->info.irq = pdev->irq;
>                 gdev->info.irq_flags = IRQF_SHARED;
>                 gdev->info.handler = irqhandler;
> --
> 2.17.1
> 
> 
>  
> 
> [cid]
> 
> *
> 


Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- Your patch was attached, please place it inline so that it can be
  applied directly from the email message itself.

- Your email was sent in html format, which is rejected by the kernel
  mailing lists and make it impossible for anyone to find in the
  archives.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot