linux-kernel - Re: [PATCH v2 5/5] usb: gadget: u

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87mtxlayf0.fsf@kernel.org>
Date:   Thu, 07 Jan 2021 11:28:35 +0200
From:   Felipe Balbi <balbi@...nel.org>
To:     Jerome Brunet <jbrunet@...libre.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Jerome Brunet <jbrunet@...libre.com>,
        Ruslan Bilovol <ruslan.bilovol@...il.com>,
        Jack Pham <jackp@...eaurora.org>, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 5/5] usb: gadget: u_audio: clean up locking

Jerome Brunet <jbrunet@...libre.com> writes:

> snd_pcm_stream_lock() is held when the ALSA .trigger() callback is called.
> The lock of 'struct uac_rtd_params' is not necessary since all its locking
> operation are done under the snd_pcm_stream_lock() too.
>
> Also, usb_request .complete() is called with irqs disabled, so saving and
> restoring the irqs is not necessary.
>
> Signed-off-by: Jerome Brunet <jbrunet@...libre.com>

This is nice!

Acked-by: Felipe Balbi <balbi@...rnel.org>

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (858 bytes)